bl1 / v2.0 fixups #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suspect due to the call function hook being thiscall, ecx was always a valid pointer, even if it pointed at garbage
been meaning to do this forever, kept forgetting
Ry0511
reviewed
Jun 14, 2025
Comment on lines
+92
to
+105
| MH_STATUS status = MH_OK; | ||
| status = MH_DisableHook(reinterpret_cast<LPVOID>(&GetStartupInfoA)); | ||
| if (status != MH_OK) { | ||
| LOG(ERROR, "Failed to disable GetStartupInfoA hook: {:x}", static_cast<uint32_t>(status)); | ||
|
|
||
| // If it fails, there isn't really any harm in leaving it active, just return | ||
| return; | ||
| } | ||
|
|
||
| status = MH_RemoveHook(reinterpret_cast<LPVOID>(&GetStartupInfoA)); | ||
| if (status != MH_OK) { | ||
| LOG(ERROR, "Failed to remove GetStartupInfoA hook: {:x}", static_cast<uint32_t>(status)); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Any reason for the duplication?
There was a problem hiding this comment.
disable vs remove? those aren't the same thing, best to clean up properly
There was a problem hiding this comment.
Ah, i'm blind just assumed they were both remove lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.